Chris Satterlee / IV Swinger 2 - History

Convert app_data_dir to Path (Issue #210)

This is one of many incremental changes to refactor the code to use pathlib Path objects. In this commit, the app_data_dir path is converted, as well as paths that have app_data_dir immediately on the RHS of their assignment. It only goes that far, though.

This commit is to the pathlib_refactor branch and will be merged to the default branch after all the other changes have been committed and thorough testing has been performed.

Update version to 2.8.2

Update from v2.8.1 to v2.8.2

Create app_data_dir in check_app_data_dir method (Issue #212)

When the instances feature was added, the sequence in the GraphicalUserInterface class __init__ method was changed. The check_app_data_dir() method is now called before the ivs2 object is created. The ivs2 object creation creates the app_data_dir folder if it doesn't exist. Since it is now called after the call to check_app_data_dir(), the creation of a dummy file in that folder fails with the FATAL ERROR for anyone that had not run the app before.

It really didn't make sense to check that it was possible to create a folder in the app_data_dir parent after the IV_Swinger2 folder had already been created anyway.

The fix is to create the app_data_dir folder in the check_app_data_dir() method if it doesn't already exist. It does this in place of creating (and removing) a dummy folder.

Improve fix for NoSectionError exception (Issue #211)

The previously committed fix for Issue #211 works but isn't really right. The parent attribute values are not related to a run displayed in the Wizard. The reason that a simulator run doesn't have the Remote Command section in its config file is that that section is added in the GUI's extension of the base Configuration class, but the simulator uses the base class. This is the same as the Looping section. The populate_looping_tab method handles this by checking for the existence of the Looping section before applying the config values to the widgets. That is the correct way to handle this, and this commit now does the same thing in the populate_rcmd_tab method.

Fix NoSectionError exception (Issue #211)

The populate_rcmd_tab method should not use the config for the port and poll_ms values; it should use the parent object's attributes. Older configs don't have these values.

Replace os.makedirs(x) with Path(x).mkdir(parents=True) (Issue #210)

This is an incremental change. For now, all instances of os.makedirs(x) are replaced with Path(x).mkdir(parents=True)

Later, all the "x" paths will themselves be changed from strings to Path objects, and these will all be changed from x.mkdir(parents=True)

Replace os.remove(x) with Path(x).unlink() (Issue #210)

This is an incremental change. For now, all instances of os.remove(x) are replaced with Path(x).unlink().

Later, all the "x" paths will themselves be changed from strings to Path objects, and these will all be changed from Path(x).unlink(x) to simply x.unlink().

Replace os.path.exists() with Path().exists() (Issue #210)

This is an incremental change. For now, all instances of os.path.exists(x) are replaced with Path(x).exists().

Later, all the "x" paths will themselves be changed from strings to Path objects, and these will all be changed from Path(x).exists(x) to simply x.exists().

Replace os.getcwd() with Path.cwd() (Issue #210)

Decided that the uses of os.getcwd() in IV_Swinger2.py and IV_Swinger2_gui.py should be removed. The current directory really cannot be the run directory. Converted the two instances in the main() function of IV_Swinger2_PV_model.py.

Update version to 2.8.1

Update from v2.8.0 to v2.8.1