SM6FBQ / HackRF clone - History

Merge pull request #1184 from martinling/flush-on-setup

Flush queues on control endpoint when a new SETUP is received.

Flush queues on control endpoint when a new SETUP is received.

On macOS 12.6 running libusb 1.0.26, the host was seen to sometimes
make an incomplete ClearFeature(ENDPOINT_HALT) request when
ClearPipeStallBothEnds was called from libusb_cancel_transfer.

The host would send the SETUP packet, and the firmware would
call usb_transfer_schedule_ack to acknowledge the upcoming IN
token. However, the host would then not send the IN token,
proceeding directly to the next SETUP.

Since an empty transfer was queued to schedule the ACK, the
firmware would leak one transfer from the free_transfers list.

After a few iterations of this, the firmware would run out of
free transfers and the next request would hang waiting for one.

Fix this by flushing the transfer queues for the control endpoint
when a new SETUP is received, since that token implicitly cancels
any previously ongoing request.

firmware: improve platform detection

Slow down the detection of pull-up and pull-down resistors to make
detection more reliable.

Hold transfer lock during initial submissions in prepare_transfers.